Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fail on unhandled warnings #2197

Merged
merged 5 commits into from
Jan 30, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 30, 2024

Copy link

codspeed-hq bot commented Jan 30, 2024

CodSpeed Performance Report

Merging #2197 will not alter performance

Comparing edgarrmondragon/test/fail-on-warnings (9299f85) with main (9bb7066)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bb7066) 88.43% compared to head (9299f85) 88.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2197   +/-   ##
=======================================
  Coverage   88.43%   88.43%           
=======================================
  Files          54       54           
  Lines        4714     4714           
  Branches      961      961           
=======================================
  Hits         4169     4169           
  Misses        384      384           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/test/fail-on-warnings branch from 268b881 to 9299f85 Compare January 30, 2024 20:18
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 30, 2024 20:22
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners January 30, 2024 20:22
@edgarrmondragon edgarrmondragon merged commit af3b678 into main Jan 30, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/test/fail-on-warnings branch January 30, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant